# FindBugs Report

## Project Information

Project:

FindBugs version: 3.0.1

Code analyzed:

- E:\bfproject\main\MeetingPlaceAdaptor\components\adaptors\CiscoMeetingPlace\build\MeetingPlaceAdaptor.jar

## Metrics

8880 lines of code analyzed, in 277 classes, in 5 packages.

Metric | Total | Density*
--- | --- | ---
High Priority Warnings | 1 | 0.11
Medium Priority Warnings | 4 | 0.45
Total Warnings | 5 | 0.56

(* Defects per Thousand lines of non-commenting source statements)

## Contents

- Internationalization Warnings
- Malicious code vulnerability Warnings
- Performance Warnings
- Details

# Summary

Warning Type | Number
--- | ---
Internationalization Warnings | 1
Malicious code vulnerability Warnings | 3
Performance Warnings | 1
Total | 5

# Warnings

Click on a warning row to see full context information.

## Internationalization Warnings

Code | Warning
--- | ---
Dm | Found reliance on default encoding in com.adobe.connect.meetingplace.adaptor.CallbackServlet.handleEvent(HttpServletRequest): String.getBytes()
| Bug type DM_DEFAULT_ENCODING (click for details) In class com.adobe.connect.meetingplace.adaptor.CallbackServlet In method com.adobe.connect.meetingplace.adaptor.CallbackServlet.handleEvent(HttpServletRequest) Called method String.getBytes() At CallbackServlet.java:[line 56]

## Malicious code vulnerability Warnings

Code | Warning
--- | ---
MS | com.adobe.connect.meetingplace.adaptor.Constants.EVENT_LIST is a mutable collection which should be package protected
| Bug type MS_MUTABLE_COLLECTION_PKGPROTECT (click for details) In class com.adobe.connect.meetingplace.adaptor.Constants Field com.adobe.connect.meetingplace.adaptor.Constants.EVENT_LIST At Constants.java:[line 41]
MS | com.adobe.connect.meetingplace.adaptor.Constants.FIELD_LIST is a mutable collection which should be package protected
| Bug type MS_MUTABLE_COLLECTION_PKGPROTECT (click for details) In class com.adobe.connect.meetingplace.adaptor.Constants Field com.adobe.connect.meetingplace.adaptor.Constants.FIELD_LIST At Constants.java:[line 81]
MS | com.adobe.connect.meetingplace.adaptor.Constants.INSTANCE_ID_TO_ADAPTOR_MAP is a mutable collection which should be package protected
| Bug type MS_MUTABLE_COLLECTION_PKGPROTECT (click for details) In class com.adobe.connect.meetingplace.adaptor.Constants Field com.adobe.connect.meetingplace.adaptor.Constants.INSTANCE_ID_TO_ADAPTOR_MAP At Constants.java:[line 75]

## Performance Warnings

Code | Warning
--- | ---
WMI | com.adobe.connect.meetingplace.adaptor.MeetingPlaceConference.handleTalkerState(List) makes inefficient use of keySet iterator instead of entrySet iterator
| Bug type WMI_WRONG_MAP_ITERATOR (click for details) In class com.adobe.connect.meetingplace.adaptor.MeetingPlaceConference In method com.adobe.connect.meetingplace.adaptor.MeetingPlaceConference.handleTalkerState(List) Field com.adobe.connect.meetingplace.adaptor.MeetingPlaceConference.userMap At MeetingPlaceConference.java:[line 425]

# Details

## DM_DEFAULT_ENCODING: Reliance on default encoding

Found a call to a method which will perform a byte to String (or String to byte) conversion, and will assume that the default platform encoding is suitable. This will cause the application behaviour to vary between platforms. Use an alternative API and specify a charset name or Charset object explicitly.

## MS_MUTABLE_COLLECTION_PKGPROTECT: Field is a mutable collection which should be package protected

A mutable collection instance is assigned to a final static field, thus can be changed by malicious code or by accident from another package. The field could be made package protected to avoid this vulnerability. Alternatively you may wrap this field into Collections.unmodifiableSet/List/Map/etc. to avoid this vulnerability.

## WMI_WRONG_MAP_ITERATOR: Inefficient use of keySet iterator instead of entrySet iterator

This method accesses the value of a Map entry, using a key that was retrieved from a keySet iterator. It is more efficient to use an iterator on the entrySet of the map, to avoid the Map.get(key) lookup.